Remove InteractiveSearchBox entirely #1769
Open
+0
−553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This widget was added in d426f62 as a copy of the original `GtkTreeView` code, with a modified timeout to the start of searching. Since then, there has been 1 additional change to functionality in bb26e53 to add support for a slightly different version of `PersistentTreeView` on `ListView`. All other changes have been minimal maintenance: fixing small bugs, replacing deprecated GTK calls, or code formatting. I contend that this is too much code to maintain for such a small change in functionality from upstream GTK, and any migration to new widgets in GTK4 will have to implement this differently anyway, so I'm proposing to remove it all. AFAICT, it still works, just with GTK's timing instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This widget was added in d426f62 as a copy of the original
GtkTreeViewcode, with a modified timeout to the start of searching. Since then, there has been 1 additional change to functionality in bb26e53 to add support for a slightly different version ofPersistentTreeViewonListView. All other changes have been minimal maintenance: fixing small bugs, replacing deprecated GTK calls, or code formatting.I contend that this is too much code to maintain for such a small change in functionality from upstream GTK, and any migration to new widgets in GTK4 will have to implement this differently anyway, so I'm proposing to remove it all. AFAICT, search still works without this code, just with GTK's timing instead.